search

aws-observability / helm-charts

The AWS Observability Helm Charts repository contains Helm charts to provide easy mechanisms to setup the CloudWatch Agent and other collection agents to collect telemetry data such as metrics, logs and traces to send to AWS monitoring services.
Apache License 2.0
9 stars 17 forks source link

Fixing helm template function call for instrumentation images in oper… #7

Closed mitali-salvi closed 7 months ago

mitali-salvi commented 7 months ago

…ator deployment

Description of changes:

  1. Operator was unable to parse the ADOT instrumentation images for both python and java because of incorrect call to helm function

Testing Ran Helm templating command to check the output

helm template amazon-cloudwatch-observability ./charts/amazon-cloudwatch-observability/ --include-crds --namespace amazon-cloudwatch --set region=us-east-1 > output.yaml

Attaching snippet

      - image: public.ecr.aws/cloudwatch-agent/cloudwatch-agent-operator:1.1.0
        args:
        - "--auto-annotation-config={\"java\":{\"daemonsets\":[],\"deployments\":[],\"namespaces\":[],\"statefulsets\":[]},\"python\":{\"daemonsets\":[],\"deployments\":[],\"namespaces\":[],\"statefulsets\":[]}}"
        - "--auto-instrumentation-java-image=public.ecr.aws/aws-observability/adot-autoinstrumentation-java:v1.32.1"
        - "--auto-instrumentation-python-image=public.ecr.aws/aws-observability/adot-autoinstrumentation-python:v0.0.1"
        - "--feature-gates=operator.autoinstrumentation.multi-instrumentation,operator.autoinstrumentation.multi-instrumentation.skip-container-validation"

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.