search

aws-observability / helm-charts

The AWS Observability Helm Charts repository contains Helm charts to provide easy mechanisms to setup the CloudWatch Agent and other collection agents to collect telemetry data such as metrics, logs and traces to send to AWS monitoring services.
Apache License 2.0
9 stars 17 forks source link

feat(fluent-bit): set system-node-critical as a default priorityClass #70

Open m00lecule opened 4 months ago

m00lecule commented 4 months ago

Issues:

54

In Kubernetes there is a good practice to specify a system-node-critical priority class for monitoring agents running as daemonsets.

ref: https://kubernetes.io/docs/tasks/administer-cluster/guaranteed-scheduling-critical-addon-pods/

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

m00lecule commented 4 months ago

@lisguo may I ask for a review?

m00lecule commented 2 months ago

@lisguo May I ask for a review again? The Integration tests are failing due to Error: Credentials could not be loaded, please check your action inputs: Could not load credentials from any providers which doesn't seem to be connected with my changes.

markandersontrocme commented 1 month ago

@m00lecule we should also add the priorityClass to the cloudwatch-agent? https://github.com/aws-observability/helm-charts/blob/main/charts/amazon-cloudwatch-observability/templates/linux/cloudwatch-agent-daemonset.yaml#L23

m00lecule commented 1 month ago

@m00lecule we should also add the priorityClass to the cloudwatch-agent? https://github.com/aws-observability/helm-charts/blob/main/charts/amazon-cloudwatch-observability/templates/linux/cloudwatch-agent-daemonset.yaml#L23

@markandersontrocme I believe so, the general principle is to ensure that monitoring agents are running on all EKS nodes

markandersontrocme commented 1 month ago

@markandersontrocme I believe so, the general principle is to ensure that monitoring agents are running on all EKS nodes

I fee like it would make sense to add that to this PR 🙏