aws-observability / helm-charts

The AWS Observability Helm Charts repository contains Helm charts to provide easy mechanisms to setup the CloudWatch Agent and other collection agents to collect telemetry data such as metrics, logs and traces to send to AWS monitoring services.
Apache License 2.0
8 stars 14 forks source link

Made helm format more intuitive for auto-instrumentation resources values. #80

Closed musa-asad closed 1 month ago

musa-asad commented 1 month ago

Description of changes: As per the latest changes to allow configurable resource requests and limits through command arguments, the formatting in values.yaml could be made more intuitive since they're values for containers, not images.

Testing:

  1. helm upgrade --install amazon-cloudwatch-observability helm-charts/charts/amazon-cloudwatch-observability --values helm-charts/charts/amazon-cloudwatch-observability/values.yaml --set clusterName=<cluster-name> --set region=us-west-2
Screenshot 2024-08-12 at 11 07 19 AM

Works the same.

  1. helm upgrade --install amazon-cloudwatch-observability helm-charts/charts/amazon-cloudwatch-observability --values helm-charts/charts/amazon-cloudwatch-observability/values.yaml --set clusterName=cloudwatchagent-operator --set region=us-west-2 --set manager.autoInstrumentationResources.java.limits.cpu=147m
Screenshot 2024-08-12 at 11 07 58 AM

Changes appropriately.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.