search

aws-observability / helm-charts

The AWS Observability Helm Charts repository contains Helm charts to provide easy mechanisms to setup the CloudWatch Agent and other collection agents to collect telemetry data such as metrics, logs and traces to send to AWS monitoring services.
Apache License 2.0
9 stars 17 forks source link

feat: Support runtime-metrics #97

Closed adebayor123 closed 3 weeks ago

adebayor123 commented 2 months ago

Relevant PR:

Description of changes: As part of supporting runtime metrics for Application Signals, we need a mechanism to allow customers to disable runtime-metrics for Addons. This PR creates a new field under manager, autoInstrumentationApplicationSignals that will be used in the cloudwatch-agent-operator to disable runtime-metrics.

E2E Testing

When runtime is set to false:

--auto-instrumentation-config={"dotnet":{"limits":{"cpu":"500m","memory":"128Mi"},"requests":{"cpu":"50m","memory":"128Mi"}},"java":{"limits":{"cpu":"500m","memory":"64Mi"},"requests":{"cpu":"50m","memory":"64Mi"},"runtime":{"enabled":false}},"nodejs":{"limits":{"cpu":"500m","memory":"128Mi"},"requests":{"cpu":"50m","memory":"128Mi"}},"python":{"limits":{"cpu":"500m","memory":"32Mi"},"requests":{"cpu":"50m","memory":"32Mi"},"runtime":{"enabled":false}}}

The namespace level configuration is set as:

OTEL_AWS_APPLICATION_SIGNALS_RUNTIME_ENABLED=false

When runtime is set to true:

--auto-instrumentation-config={"dotnet":{"limits":{"cpu":"500m","memory":"128Mi"},"requests":{"cpu":"50m","memory":"128Mi"}},"java":{"limits":{"cpu":"500m","memory":"64Mi"},"requests":{"cpu":"50m","memory":"64Mi"},"runtime":{"enabled":true}},"nodejs":{"limits":{"cpu":"500m","memory":"128Mi"},"requests":{"cpu":"50m","memory":"128Mi"}},"python":{"limits":{"cpu":"500m","memory":"32Mi"},"requests":{"cpu":"50m","memory":"32Mi"},"runtime":{"enabled":true}}}

The namespace level configuration is set as:

OTEL_AWS_APPLICATION_SIGNALS_RUNTIME_ENABLED=true

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.