search

aws-powertools / powertools-lambda-dotnet

Powertools is a developer toolkit to implement Serverless best practices and increase developer velocity.
https://docs.powertools.aws.dev/lambda/dotnet/
MIT No Attribution
152 stars 24 forks source link

chore: Sync main with develop #566

Closed hjgraca closed 5 months ago

hjgraca commented 5 months ago

Please provide the issue number

Issue number: #563

Summary

Sync branch

Changes

Please provide a summary of what's being changed

User experience

Please share what the user experience looks like before and after this change

Checklist

Please leave checklist items unchecked if they do not apply to your change.

Is this a breaking change? **RFC issue number**: Checklist: * [ ] Migration process documented * [ ] Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

sonarcloud[bot] commented 5 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
2.6% Duplication on New Code

See analysis details on SonarCloud

codecov-commenter commented 5 months ago

Codecov Report

Attention: Patch coverage is 59.94695% with 151 lines in your changes are missing coverage. Please review.

Project coverage is 72.37%. Comparing base (6286cad) to head (9148d02). Report is 37 commits behind head on main.

Files Patch % Lines
...wertools.Parameters/AppConfig/AppConfigProvider.cs 58.85% 73 Missing and 6 partials :warning:
...rnal/AppConfig/AppConfigJsonConfigurationParser.cs 53.22% 27 Missing and 2 partials :warning:
...AppConfig/AppConfigProviderConfigurationBuilder.cs 73.91% 14 Missing and 4 partials :warning:
....Lambda.Powertools.Parameters/ParametersManager.cs 0.00% 15 Missing :warning:
...ternal/AppConfig/AppConfigDictionaryTransformer.cs 53.84% 3 Missing and 3 partials :warning:
...s/Internal/AppConfig/AppConfigFeatureFlagHelper.cs 63.63% 2 Missing and 2 partials :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #566 +/- ## ========================================== - Coverage 74.10% 72.37% -1.73% ========================================== Files 101 109 +8 Lines 4112 4489 +377 Branches 418 455 +37 ========================================== + Hits 3047 3249 +202 - Misses 951 1106 +155 - Partials 114 134 +20 ``` | [Flag](https://app.codecov.io/gh/aws-powertools/powertools-lambda-dotnet/pull/566/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/aws-powertools/powertools-lambda-dotnet/pull/566/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | `72.37% <59.94%> (-1.73%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.