search

aws-powertools / powertools-lambda-dotnet

Powertools is a developer toolkit to implement Serverless best practices and increase developer velocity.
https://docs.powertools.aws.dev/lambda/dotnet/
MIT No Attribution
152 stars 24 forks source link

Feature request: Reduce use of lesser known packages in Idemopotency package #568

Closed mungojam closed 4 months ago

mungojam commented 5 months ago

Use case

We have to be careful with the dependencies that we bring in. The Idempotency package brings in a JmesPath package which then brings in other sub-packages. The sub-packages are particularly obscure, developed as a university project with very few users. https://www.nuget.org/packages/Springcomp.GPPG.Runtime

We would like the JmesPath package dependency to be replaced with native System.Text.Json functionality, or else a more widely used package (e.g. Newtonsoft.Json).

Otherwise I don't think we will be able to make use of the Idempotency package.

Solution/User Experience

It seems that the main use is here, and could be replaced with a System.Text.Json use:

https://github.com/aws-powertools/powertools-lambda-dotnet/blob/develop/libraries/src/AWS.Lambda.Powertools.Idempotency/Serialization/JsonFunction.cs

Alternative solutions

No response

Acknowledgment

boring-cyborg[bot] commented 5 months ago

Thanks for opening your first issue here! We'll come back to you as soon as we can. In the meantime, check out the #dotnet channel on our Powertools for AWS Lambda Discord: Invite link

hjgraca commented 5 months ago

@mungojam Thanks for raising this feature request. We are discussing what you wrote between the team and will get back to you soon. I agree with you, the less dependencies we have the better, if we can achieve the same functionality with System.Text.Json seems like a good approach to me.

hjgraca commented 4 months ago

Hi @mungojam just to give you an update: PR created #578

hjgraca commented 3 months ago

@mungojam Release 1.10.0 removes dependency on 3rd party JMESPath. Using Idempotency 1.2.1 will not have that external dependency. Hope you find it useful and reach out if you have any other questions or suggestions. Thanks

mungojam commented 3 months ago

@hjgraca nice one, thanks for the change. We'll look to adopt it now as nothing blocking anymore