aws-powertools / powertools-lambda-dotnet

Powertools is a developer toolkit to implement Serverless best practices and increase developer velocity.
https://docs.powertools.aws.dev/lambda/dotnet/
MIT No Attribution
152 stars 24 forks source link

chore: Tracing add AOT support #607

Closed hjgraca closed 1 month ago

hjgraca commented 2 months ago

Please provide the issue number

Issue number: #212

Summary

Tracing support for AOT

Changes

Remove dependency from UniversalWrapperAspect.cs and refactor Tracing attribute/decorator .NET8 specific paths in code Refactor TracingAttributeTest.cs no more mocks

User experience

Please share what the user experience looks like before and after this change

Checklist

Please leave checklist items unchecked if they do not apply to your change.

Is this a breaking change? **RFC issue number**: Checklist: * [ ] Migration process documented * [ ] Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 98.27586% with 1 line in your changes missing coverage. Please review.

Project coverage is 72.41%. Comparing base (eef0ea8) to head (5f2b82a).

Files Patch % Lines
...ambda.Powertools.Tracing/Internal/TracingAspect.cs 98.27% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #607 +/- ## =========================================== - Coverage 72.44% 72.41% -0.03% =========================================== Files 190 190 Lines 7897 7874 -23 Branches 852 850 -2 =========================================== - Hits 5721 5702 -19 + Misses 1888 1878 -10 - Partials 288 294 +6 ``` | [Flag](https://app.codecov.io/gh/aws-powertools/powertools-lambda-dotnet/pull/607/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aws-powertools) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/aws-powertools/powertools-lambda-dotnet/pull/607/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aws-powertools) | `72.41% <98.27%> (-0.03%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aws-powertools#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

sonarcloud[bot] commented 1 month ago

Quality Gate Passed Quality Gate passed

Issues
12 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud