chore: Fix metrics lambda context and storage resolution

hjgraca commented 1 month ago

Please provide the issue number

Issue number: #612

Summary

WIth the new AOT release there was a problem at runtime with the serializaton of LambdaContext when capturing cold starts, the funcionname was not being set

There is also a issue with StorageResolution serialization not serializing to int instead is serializing the string "High"

Changes

Removed the dependency of reflection for LambdaContext and bring the Amazon.Lambda.Core.ILambdaContext to Metrics.
Add a new MetricResolutionJsonConverter to serialize StorageResolution correctly
Remove the custom serialization StringEnumConverter for MetricsUnit and add the default JsonStringEnumConverter

User experience

Please share what the user experience looks like before and after this change

Checklist

Please leave checklist items unchecked if they do not apply to your change.

[x] Meets tenets criteria
[x] I have performed a self-review of this change
[x] Changes have been tested
[ ] Changes are documented
[x] PR title follows conventional commit semantics

Is this a breaking change?

**RFC issue number**: Checklist: * [ ] Migration process documented * [ ] Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 72.43%. Comparing base (33546b4) to head (7f4d676).

Additional details and impacted files

```diff @@ Coverage Diff @@ ## develop #613 +/- ## =========================================== - Coverage 72.58% 72.43% -0.15% =========================================== Files 190 190 Lines 7900 7897 -3 Branches 850 852 +2 =========================================== - Hits 5734 5720 -14 - Misses 1876 1889 +13 + Partials 290 288 -2 ``` | [Flag](https://app.codecov.io/gh/aws-powertools/powertools-lambda-dotnet/pull/613/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aws-powertools) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/aws-powertools/powertools-lambda-dotnet/pull/613/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aws-powertools) | `72.43% <100.00%> (-0.15%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aws-powertools#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

hjgraca commented 1 month ago

Not sure why is failing but codecov is green when going to the details

aws-powertools / powertools-lambda-dotnet