build(deps): bump com.networknt:json-schema-validator from 1.0.87 to 1.4.3

[justin-tay]

Issue #, if available: #1663

Description of changes:

Upgrades com.networknt:json-schema-validator to 1.4.3.

Note that the validation error messages have changed since 1.0.87.

{
  "validationErrors": [
    {
      "type": "enum",
      "code": "1008",
      "message": "/properties/name/type: does not have a value in the enumeration [array, boolean, integer, null, number, object, string]",
      "instanceLocation": "/properties/name/type",
      "evaluationPath": "/properties/properties/additionalProperties/$ref/properties/type/anyOf/0/$ref/enum",
      "schemaLocation": "http://json-schema.org/draft-07/schema#/definitions/simpleTypes/enum",
      "messageKey": "enum",
      "arguments": [
        "[array, boolean, integer, null, number, object, string]"
      ]
    },
    {
      "type": "type",
      "code": "1029",
      "message": "/properties/name/type: string found, array expected",
      "instanceLocation": "/properties/name/type",
      "evaluationPath": "/properties/properties/additionalProperties/$ref/properties/type/anyOf/1/type",
      "schemaLocation": "http://json-schema.org/draft-07/schema#/properties/type/anyOf/1/type",
      "messageKey": "type",
      "arguments": [
        "string",
        "array"
      ]
    }
  ]
}

Checklist

* [x] [Meet tenets criteria](https://docs.powertools.aws.dev/lambda-java/#tenets) * [x] Update tests * [ ] Update docs * [x] PR title follows [conventional commit semantics](https://www.conventionalcommits.org/en/v1.0.0/) ## Breaking change checklist

RFC issue #:

• [ ] Migration process documented
• [ ] Implement warnings (if it can live side by side)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

[jeromevdl]

Thanks for submitting this PR. It looks good to me but I have 3 questions.

• Is there any breaking change compared to previous version: can we reuse the same schema files? is the validation the same (appart from the output message)? ...?
• Do we need to update the documentation to reflect this change? If yes, can you do it part of this PR.
• Did you test on Lambda? Because I remember we had some problem with the "online" schemas on Lambda (see https://github.com/networknt/json-schema-validator/issues/867).
  • We may need to do something like this

    JsonSchemaFactory jsonSchemaFactory = JsonSchemaFactory.getInstance(VersionFlag.V202012, builder -> 
    builder.schemaMappers(schemaMappers -> schemaMappers.mapPrefix("https://www.example.org/", "classpath:schema/"))
    );

[justin-tay]

Thanks for submitting this PR. It looks good to me but I have 3 questions.

• Is there any breaking change compared to previous version: can we reuse the same schema files? is the validation the same (appart from the output message)? ...?

There were breaking API changes, but given that it doesn't seem like this library provides much options to customize the validator I'm not sure it applies here, like if users had custom keyword or format implementations etc that would require code changes.

This fixes a lot of issues with respect to compliance with the specifications with respect to the validation so if users relied on incorrect behavior that will break. For instance previously certain keywords for 2019-09 and in particular 2020-12 didn't work eg $dynamicRef, $dynamicAnchor.

• https://bowtie.report/#/implementations/java-networknt-json-schema-validator
• https://www.creekservice.org/json-schema-validation-comparison/functional#summary-of-results

• Do we need to update the documentation to reflect this change? If yes, can you do it part of this PR.

I'm not really sure which aspect of the documentation would require updating. The message is likely the most visible change.

• Did you test on Lambda? Because I remember we had some problem with the "online" schemas on Lambda (see http error 403 when accessing https://json-schema.org/draft/2019-09/meta/core networknt/json-schema-validator#867).

  • We may need to do something like this

JsonSchemaFactory jsonSchemaFactory = JsonSchemaFactory.getInstance(VersionFlag.V202012, builder -> 
    builder.schemaMappers(schemaMappers -> schemaMappers.mapPrefix("https://www.example.org/", "classpath:schema/"))
);

There's actually no need to do that for the standard schema dialects because the MetaSchemaMapper will map the standard dialects to the classpath but in this case this library already maps them to the classpath which I opted to retain since I'm not sure if the intent was to prevent users from pulling other resources from https etc and only allow classpath resources.

• https://github.com/aws-powertools/powertools-lambda-java/blob/3440513161818a7bedae3a0558f9ff88cd248af6/powertools-validation/src/main/java/software/amazon/lambda/powertools/validation/ValidationUtils.java#L277-L286

[jeromevdl]

@justin-tay, Can you try to run the two end-to-end tests in powertools-e2e-tests ? Then if it works we should be good. Thank you.

[justin-tay]

Will there be any costs involved running the two end-to-end tests in powertools-e2e-tests?

[jeromevdl]

The ValidationApiGWE2ET is based on API GW / Lambda, and you have free tier with these services so it should not cost anything. Do not test the ALB one if you don't want to expense anything.

[justin-tay]

I only ran ValidationApiGWE2ET but I expect that ValidationALBE2ET should also pass with the updated messages.

[INFO] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 51.41 s -- in software.amazon.lambda.powertools.ValidationApiGWE2ET
[INFO]
[INFO] Results:
[INFO]
[INFO] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0
[INFO]
[INFO]