Docs: Move code snippets into dedicated python files add formatting and linting, fixing any outstanding errors

[michaelbrewer]

Is your feature request related to a problem? Please describe.

• 1067

• 1069

• 1207

• 1211

• 1212

• 1213

• 1214

• 1215

• 1216

• 1217

• 1223

• or see Additional context for a summary

Describe the solution you'd like

In the past there was many documentation errors found like #1004 , on a regular basis i would try to help the community by verifying the code examples, that they can compile, linted, valid formatting and had the correct line highlights

As part of general papercuts #857 and then later #1009 it was decided to split up the examples into separate files so that they can be linted or validates.

Currently the AWS Lambda Documentation has many typos, syntax errors, missing imports, invalid yaml indentation and terraform errors (about 25 errors currently and we keeping on running into this errors each time code examples are updated or added (see #1004). Here is a list of some of them as separate issues:

Hosted version of this is at: https://gyft.github.io/aws-lambda-powertools-python/latest/

Describe alternatives you've considered

Keeping the examples inside the markdown docs. But we run into issues like below, where errors are not easily picked up

Additional context

As a side effect many existing errors will be resolved AND measures put in to prevent them from happening again. Here is a list of errors currently in the documentation

• [x] Includes #1068 HomePage - Lambda Layer - Terraform example
• [x] Fix python syntax HomePage - SAR - CDK examples
• [x] Fix template yml indents HomePage - Example: Least-privileged IAM permissions to deploy Layer example
• [x] Open external links in a new tab for Tracer - page
• [x] Fix example in Logger - FAQ section Cloning Logger config to all other registered standard loggers which results in a error AttributeError: module 'logging' has no attribute 'logger' on line 8
• [x] Fix metrics SAM Metrics - template.yml indents
• [x] Fix missing imports for Metrics - Clear metrics tests
• [x] Fix python syntax on Metrics - Assert multiple EMF blobs with pytest example
• [x] Fix SAM example for Rest api (and fixes #1069) REST API : Required resources
• [x] Fix json response example in Rest API - Fine grained response - Not formatted as json
• [x] Fix missing import for Parameters - Creating a S3 Provider to fetch parameters example
• [x] Fix examples in Batch - Pydantic integration
• [x] Clean up Batch - Accessing processed messages via context manager example removing unused imports and fix line highlights.
• [x] Fix missing imports in Batch - Extending failure handling mechanism in BatchProcessor example
• [x] Fix python syntax errors in Batch -Testing your code examples
• [x] Fix missing parameter in success_handler Batch - Creating a custom batch processor example
• [x] Fix import for Batch - Customizing boto configuration example
• [x] Fix name for validator_function.py example, see Validation - Validate function
• [x] Fix ht_line invalid syntax in Validation - Validating custom formats - schema.py
• [x] Fix missing imports for Parser - EventBridge Envelope example
• [x] Fix yaml indent in Idempotency -AWS Serverless Application Model (SAM) example
• [x] Fix python syntax in Idempotency - Exception not affecting idempotency record sample example
• [x] Fix python syntax in Idempotency - Reusing a DynamoDB table that uses a composite primary key example
• [x] Fix python syntax in Idempotency - Using Idempotency with JSONSchema Validation utility example
• [x] Fix Deserializing JSON before using as idempotency key example in JMESPath Functions - page - Missing import
• [x] Fix custom_jmespath_function.py example in JMESPath Functions - page - Invalid python syntax

List of open pull requests

Originally part of a simple PR #1065 but now split up into smaller ones

• 1113

• 1137

• 1126

• 1121

• 1122

• 1117

• 1116

• 1123

• 1124

• 1114

• 1127

• 1128

• 1115

• 1125

• 1119

• 1118

• 1120

[michaelbrewer]

I have a pull request that partially fixes this (as there is a lot of examples to migrate). So once there is feedback on this I can continue.

[michaelbrewer]

@heitorlessa @sthulb - as part of the original papercuts, we had discuss how many errors we have fund in the code examples, and that extracting them into separate files would allow us to add formatting (isort, black), check for syntax error (py_compile) and perform linting (cfn-lint etc..).

So in a series of pull requests, i have extracted and fixes all of the code examples (python, terraform and sam templates) and fixed (over 25 errors so far). Some of these pull requests has quite a few errors and some just have smaller formatting inconsistencies.

[sthulb]

The pull requests associated with this issue will be resolved eventually. There’s a lot of them and they’re quite large too.

[michaelbrewer]

Yep and covers 25 error in the docs too

[michaelbrewer]

Updated preview of fixed docs is hosted here: https://gyft.github.io/aws-lambda-powertools-python/latest/

Up to version 1.25.10

[michaelbrewer]

@sthulb i have adding all of the missing bug reports for syntax errors identified from this task.

[michaelbrewer]

Updated preview of fixed docs is hosted here: gyft.github.io/aws-lambda-powertools-python/latest

Up to version 1.26.1

[github-actions[bot]]

Comments on closed issues are hard for our team to see.