Closed heitorlessa closed 1 month ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 96.43%. Comparing base (
e14e768
) to head (395f1ad
). Report is 563 commits behind head on develop.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@leandrodamascena can I get your help in doing your crazy QA skills just in case I missed any edge case?
Issues
0 New issues
0 Accepted issues
Measures
0 Security Hotspots
No data about Coverage
2.3% Duplication on New Code
@leandrodamascena can I get your help in doing your crazy QA skills just in case I missed any edge case?
Hey @heitorlessa, I've spent some time testing various scenarios with different kinds of Resolvers, including Bedrock, and everything seems to be working fine for me. CORS is working correctly also, and it's also running Middleware with the OPTIONS method/route.
e2e tests are also green. A note for the future is to create e2e tests with Middleware to ensure that we are testing those scenarios.
Issue number: #3916
Summary
This PR addresses the bug where non-matched routes (404) did not kick off the request chain and instead immediately process a 404 response.
The reasons this PR do not reach for a 404 middleware solution are:
__call__()
)Changes
unrelated
User experience
Checklist
If your change doesn't seem to apply, please leave them unchecked.
Is this a breaking change?
**RFC issue number**: Checklist: * [ ] Migration process documented * [ ] Implement warnings (if it can live side by side)Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.