Open heitorlessa opened 6 days ago
mypy is failing after correcting snippets; will look at that last as there's one major piece of doc to create yet
Hey @heitorlessa! 90% of the errors are related to the table_name variable.
Argument "table_name" to "DynamoDBPersistenceLayer" has incompatible type "str | None"; expected "str"
This is because the DynamoDBPersistenceLayer
class doesnt accept None
for table_name parameter and the default return for os.getenv
is None
when it don't find the env variable.
I think we can do this:
table = os.getenv("IDEMPOTENCY_TABLE", "")
WDYT?
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 96.45%. Comparing base (
e14e768
) to head (6a0364d
). Report is 679 commits behind head on develop.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Issue number: #4197
Summary
This PR refreshes Idempotency docs with newer features like cards, improves wording and navigation from ServerlessDays ANZ feedback, and add a new section to call out guarantees/caveats upfront.
Changes
Guarantee
orCaveats
sectionIdempotencyValidationError
in code snippetpowertools_json
as it was incorrectUnrelated
Tech Debt
User experience
Checklist
If your change doesn't seem to apply, please leave them unchecked.
Is this a breaking change?
**RFC issue number**: Checklist: * [ ] Migration process documented * [ ] Implement warnings (if it can live side by side)Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.