aws-powertools / powertools-lambda-typescript

Powertools is a developer toolkit to implement Serverless best practices and increase developer velocity.
https://docs.powertools.aws.dev/lambda/typescript/latest/
MIT No Attribution
1.57k stars 138 forks source link

Docs: fix install & deploy instructions for CDK example app #3029

Closed dreamorosi closed 1 month ago

dreamorosi commented 1 month ago

What were you searching in the docs?

[!note] This issue was opened on behalf of a feedback received internally.

The install and deploy commands in the CDK app present in examples/app are incorrect and don't take into account that the workspace is part of the larger monorepo. This causes the dependencies to be installed at the root of the project, which can cause issues with CDK deployment depending on where the deploy command is run.

Is this related to an existing documentation section?

https://github.com/aws-powertools/powertools-lambda-typescript/tree/main/examples/app

How can we improve?

Switch to local install and explain why we are using this command.

Got a suggestion in mind?

No response

Acknowledgment

github-actions[bot] commented 1 month ago

⚠️ COMMENT VISIBILITY WARNING ⚠️

This issue is now closed. Please be mindful that future comments are hard for our team to see.

If you need more assistance, please either tag a team member or open a new issue that references this one.

If you wish to keep having a conversation with other community members under this issue feel free to do so.

github-actions[bot] commented 1 month ago

This is now released under v2.8.0 version!