aws-powertools / powertools-lambda-typescript

Powertools is a developer toolkit to implement Serverless best practices and increase developer velocity.
https://docs.powertools.aws.dev/lambda/typescript/latest/
MIT No Attribution
1.56k stars 135 forks source link

chore(layers): add Parser to layer #3101

Closed scratchclaggy closed 6 days ago

scratchclaggy commented 1 week ago

Summary

Small PR to add the new parser feature to the published lambda layers.

Changes

Please provide a summary of what's being changed

Adds the feature to the layer stacks in the layer package.

Please add the issue number below, if no issue is present the PR might get blocked and not be reviewed

Issue number: #3100


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

boring-cyborg[bot] commented 1 week ago

Thanks a lot for your first contribution! Please check out our contributing guidelines and don't hesitate to ask whatever you need. In the meantime, check out the #typescript channel on our Powertools for AWS Lambda Discord: Invite link

scratchclaggy commented 1 week ago

This is my first PR against this project, so please let me know if I am missing anything here.

Also, could someone please confirm that the changes from this PR will trigger a new layer to be built, and following this the documentation will be updated automatically.

am29d commented 1 week ago

Hey @scratchclaggy, can you also add the package to our e2e tests. We usually check if the package is present and can be imported.

While we invoke some of the utilities in our canary lambda directly, i.e. logger and metrics. I think we can also run a parse small parse command with a fairly trivial payload, just to be sure that it's safe.

sonarcloud[bot] commented 1 week ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

boring-cyborg[bot] commented 6 days ago

Awesome work, congrats on your first merged pull request and thank you for helping improve everyone's experience!