search

aws-quickstart / cdk-eks-blueprints

AWS Quick Start Team
Apache License 2.0
430 stars 190 forks source link

[Docs] FluxCD - Use basic access auth for GitHub #1000

Closed JamesMcMahon closed 1 month ago

JamesMcMahon commented 1 month ago

Fixes issue described https://github.com/aws-quickstart/cdk-eks-blueprints/issues/999.

Short version: the GitHub API for cloning doesn't work with bearer token.

Issue #, if available:

https://github.com/aws-quickstart/cdk-eks-blueprints/issues/999

Description of changes:

Update example to use GitHub basic access authentication. Note: I don't currently have access to an AWS cluster so I would appreciate if someone could double check my changes against a running cluster.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

elamaran11 commented 1 month ago

@JamesMcMahon LGTM. Did you get a chance to test the functionality fully? Any logs you can share its working?

elamaran11 commented 1 month ago

/do-e2e-test

elamaran11 commented 1 month ago

/do-e2e-tests

elamaran11 commented 1 month ago

/do-e2e-tests

JamesMcMahon commented 1 month ago

@JamesMcMahon LGTM. Did you get a chance to test the functionality fully? Any logs you can share its working?

No - this is loosely based off work I have done fairly recently. Unfortunately, as I called out in the description, I no longer have access to a running cluster.

Would appreciate a double check.

elamaran11 commented 1 month ago

@JamesMcMahon Sure, Can you merge from main, we had a recent merge.