search

aws-quickstart / cdk-eks-blueprints

AWS Quick Start Team
Apache License 2.0
460 stars 207 forks source link

Additional Settings to VpcCniAddOn #1044

Closed PeterKoegel closed 1 month ago

PeterKoegel commented 4 months ago

This PR adds support to provide values for certain settings of the VpcCniAddOn that were introduced in amazon-vpc-cni-k8s v1.16.0 in PR additional settings to the helm chart

I verified that this code change does not introduce any functional changes for the already existing vpc-cni settings by comparing the generated cloud formation output for different sets of parameters generated with and without this change and assure they are equal. For the newly introduced vpc-cni settings I tested that they are deployed to an eks ckuster as desired.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

PeterKoegel commented 3 months ago

The schema that is returned by aws eks describe-addon-configuration --addon-name vpc-cni --addon-version v1.18.1-eksbuild.1 shows that there are some properties defines as format: integer, type: string while some of the properties that are introduced by this PR are defined as type: integer in the VPC-CNI addon's config. So it is not possible anymore to convert all integers into strings. Instead JSON.stringify() is called at assignment of each parameter with format: boolean, type: string or format: integer, type: string.