aws-quickstart / cdk-eks-blueprints

AWS Quick Start Team
Apache License 2.0
460 stars 207 forks source link

Set S3 Bucket location for code pipeline to store its artifacts with blueprints.CodePipelineStack.builder #1072

Open dmalia1 opened 3 months ago

dmalia1 commented 3 months ago

Describe the feature

This would add a method like .bucketName() or something to the builder that would use the bucketName provided. If the bucket doesn't exist, create it, otherwise use it, and put the data in a sub-bucket/folder, or use the full path provided.

Use Case

Generating many pipelines can run into S3 bucket limits. Being able to re-use an existing bucket would eliminate the bucket issue.

Proposed Solution

Add new method to blueprints.CodePipelineStack.builder() maybe called bucketName(), which takes in the bucket name/path, and KMS key ARN for encryption, then in code-pipeline.ts, where it creates the CodePipeline, pass in the value of artifactBucket to the parameters of the CodePipeline

Other Information

No response

Acknowledgements

CDK version used

2.147.3

EKS Blueprints Version

1.15.1

Node.js Version

v20.17.0

Environment details (OS name and version, etc.)

ubuntu 24.04

shapirov103 commented 2 months ago

Accepted, good feature to add.

muckelba commented 1 month ago

I just came across the same problem with too many pipelines. Until the feature arrives, i'll just delete the buckets (automatically) after i delete the pipeline.