aws-quickstart / cdk-eks-blueprints

AWS Quick Start Team
Apache License 2.0
446 stars 198 forks source link

karpenter: cloudformation deployment fails #428

Closed tusharf5 closed 2 years ago

tusharf5 commented 2 years ago

Describe the bug

With the new blueprint version v1.0.3, the blueprintmanifestdefaultprovisioner resource in cloudformation fails with the following error.

Received response status [FAILED] from custom resource. Message returned: Error: b'error: error validating "/tmp/manifest.yaml": error validating data: ValidationError(Provisioner.spec.taints): invalid type for sh.karpenter.v1alpha5.Provisioner.spec.taints: got "map", expected "array"; if you choose to ignore these errors, turn validation off with --validate=false\n'

Expected Behavior

I was expecting it to just work after upgrading to version from 1.0.3 from 1.0.2. No other changes were deployed.

Current Behavior

Blueprint pipeline failed.

Reproduction Steps

Can just deploy a blueprint project with karpenter addon.

Possible Solution

maybe need to update the custom resource python lambda function as seen in the error

Additional Information/Context

No response

CDK CLI Version

2.29.1

EKS Blueprints Version

1.0.3

Node.js Version

16.14.2

Environment details (OS name and version, etc.)

macOS

Other information

No response

youngjeong46 commented 2 years ago

@tusharf5 We just released 1.0.4 with the fixes in. Please take a look and let me know if it works on your end.

tusharf5 commented 2 years ago

@youngjeong46 I'll try it and #427 this weekend. Thanks for the quick fix.

tusharf5 commented 2 years ago

Works now. Thanks.