aws-quickstart / cdk-eks-blueprints

AWS Quick Start Team
Apache License 2.0
454 stars 205 forks source link

(feat: addons Karpenter) support consolidation in Karpenter 0.15 #486

Closed javydekoning closed 2 years ago

javydekoning commented 2 years ago

Describe the feature

Karpenter 0.15 introduces a new configuration.

spec:
  # Enables consolidation which attempts to reduce cluster cost by both removing un-needed nodes and down-sizing those
  # that can't be removed.  Mutually exclusive with the ttlSecondsAfterEmpty parameter.
  consolidation:
    enabled: true

This needs to be added to https://github.com/aws-quickstart/cdk-eks-blueprints/blob/f7fba04f2488556366779e56ebb88d860747aa5a/lib/addons/karpenter/index.ts

I suggest we default to True if not provided.

Use Case

consolidation which attempts to reduce cluster cost by both removing un-needed nodes and down-sizing those that can't be removed. Mutually exclusive with the ttlSecondsAfterEmpty parameter.

Proposed Solution

Something like:

consolidation?: {
    'enabled': boolean,
}

const consolidation = this.options.consolidation || { consolidation: { enabled: true }};

Other Information

No response

Acknowledgements

CDK version used

N/A

EKS Blueprints Version

1.2.0

Node.js Version

N/A

Environment details (OS name and version, etc.)

N/A

youngjeong46 commented 2 years ago

@javydekoning thanks for the submission. We haven't up-ed our support of Karpenter to 0.15, so it will be in a future PR with some of the other ongoing Karpenter issues (your others included.)

youngjeong46 commented 2 years ago

I have a PR in flight that takes care of this issue (and upgrade to 0.16 support). Your other issue, as I mentioned in the ticket, will have to be a followup due to breaking changes.

youngjeong46 commented 2 years ago

Addressed (and upgraded to 0.16 support) Per PR #489. Closing the issue.