aws-quickstart / cdk-eks-blueprints

AWS Quick Start Team
Apache License 2.0
446 stars 198 forks source link

[efs-csi-driver] Option to use `HelmAddOn` or `CoreAddOn` extension #866

Open vumdao opened 10 months ago

vumdao commented 10 months ago

Describe the feature

The current implement of EfsCsiDriverAddOn class extends HelmAddOn therefore it use self-managed AddOns not the AWS managed AddOns as ebs-csi-driver or vpc-cni.

Use Case

I would like to have option to decided use self-managed or AWS-managed AddOns

Proposed Solution

No response

Other Information

No response

Acknowledgements

CDK version used

2.102.0

EKS Blueprints Version

1.12.0

Node.js Version

v20.8.1

Environment details (OS name and version, etc.)

macOS Sonoma 14.0

github-actions[bot] commented 7 months ago

This issue has been automatically marked as stale because it has been open 60 days with no activity. Remove stale label or comment or this issue will be closed in 10 days

github-actions[bot] commented 5 months ago

Issue closed due to inactivity.

shapirov103 commented 5 months ago

Let's look into this for 1.15

github-actions[bot] commented 2 months ago

This issue has been automatically marked as stale because it has been open 60 days with no activity. Remove stale label or comment or this issue will be closed in 10 days

vumdao commented 2 months ago

Hi @shapirov103 , I still see EfsCsiDriverAddOn using HelmAddOn and there's no option to override to use CoreAddOn in v1.15.1

shapirov103 commented 2 months ago

Hi @vumdao , yes it has not been addressed yet. I will prioritize, but please let me know if there is an actual practical benefit to run the core addon other than it being shown in the AWS console? Core addons are produced from the helm chart, and both are maintained by AWS. Curious, if you observe better configurability options.

thpham commented 2 months ago

@shapirov103, I'm in progress of writing it, I needed it in the context of a service catalog product, the following clusterInfo.cluster.stack.region is giving me an undefined image host domain.

vumdao commented 2 months ago

@shapirov103 If I have issue with EFS mounting and then ask AWS support, they will request to install Amazon managed add-on instead of using helm chart. Plus, I prefer using Core addons to visualize them in AWS EKS console

thpham commented 2 months ago

If I have issue with EFS mounting and then ask AWS support, they will request to install Amazon managed add-on instead of using helm chart. Plus, I prefer using Core addons to visualize them in AWS EKS console

Hello, @vumdao. I faced similar issue with EFS mounting with dynamic_provisioning. I had to add: here

efsFileSystem.addToResourcePolicy(
      new iam.PolicyStatement({
        effect: iam.Effect.ALLOW,
        principals: [new iam.AnyPrincipal()],
        actions: [
          "elasticfilesystem:ClientMount",
        ],
        conditions: {
          Bool: {
            "elasticfilesystem:AccessedViaMountTarget": "true"
          },
        },
      })
    )

I hope it helps, I will prepare a PR eventually by the end of the week / weekend.