Fix CloudWatch Insights Addon - User passed version not being respected

aws-quickstart / cdk-eks-blueprints

AWS Quick Start Team

Apache License 2.0

424 stars 188 forks source link

Closed 5herlocked closed 2 months ago

5herlocked commented 2 months ago

Added test cases to ensure all information is being passed downstream.

Issue #, if available: #948

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

5herlocked commented 2 months ago

Ack.

Will submit an update to this tomorrow.

shapirov103 commented 2 months ago

@5herlocked what is the ETA to address review feedback?

5herlocked commented 2 months ago

ETA for reworked code is 03/20

5herlocked commented 2 months ago

Rebased from main before committing, I apologize, will fix commit history.

5herlocked commented 2 months ago

Tested with and without credentials in the environment. Feel free to e2e

elamaran11 commented 2 months ago

/do-e2e-tests