search

aws-quickstart / cdk-eks-blueprints

AWS Quick Start Team
Apache License 2.0
424 stars 188 forks source link

Fix Karpenter addon not return null for instanceStorePolicy as default #960

Closed vumdao closed 2 months ago

vumdao commented 2 months ago

Issue #, if available:

7:34:19 PM | UPDATE_FAILED        | Custom::AWSCDK-EKS-KubernetesResource | selvcd1deveksbluep...detemplate2CEE3EE4
Received response status [FAILED] from custom resource. Message returned: Error: b'The EC2NodeClass "default-ec2nodeclass" is invalid: \n* spec.instanceStorePolicy: Unsupported value: "": supported values: "RAID0"\n* <
nil>: Invalid value: "null": some validation rules were not checked because the object was invalid; correct the existing errors to complete validation\n'

Logs: /aws/lambda/DeployDev-sel-vc-d1-dev-eks-bluepr-Handler886CB40B-h954A8KfTkdY

Description of changes: Return null value for instanceStorePolicy as default value

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

shapirov103 commented 2 months ago

Pending e2e. (Test account is in maintenance mode atm, ETA 1 day).

shapirov103 commented 2 months ago

/do-e2e-tests

vumdao commented 2 months ago

@shapirov103 When will we have a release/hotfix for this, my blueprint project is being failed without this.

shapirov103 commented 2 months ago

@vumdao planning today or Monday.

shapirov103 commented 2 months ago

1.14.1 is out.