search

aws-quickstart / cdk-eks-blueprints

AWS Quick Start Team
Apache License 2.0
424 stars 188 forks source link

(addon/AdotCollectorAddOn): Avoiding CoreAddonProps to be filled #972

Closed Falco152 closed 1 month ago

Falco152 commented 2 months ago

Describe the bug

If using CoreAddonProps, requires version to be filled

Expected Behavior

If want to use the default auto, version could be omitted

Current Behavior

Argument of type '{ namespace: string; }' is not assignable to parameter of type 'AdotCollectorAddOnProps'. Property 'version' is missing in type '{ namespace: string; }' but required in type 'Omit<CoreAddOnProps, "saName" | "addOnName">'.

Reproduction Steps

new blueprints.addons.AdotCollectorAddOn({ namespace: "adot-collector", }),

Possible Solution

No response

Additional Information/Context

No response

CDK CLI Version

2.134.0

EKS Blueprints Version

1.14.1

Node.js Version

v20.12.0

Environment details (OS name and version, etc.)

mac 14.3.1

Other information

No response

elamaran11 commented 2 months ago

@Falco152 Thankyou for submitting this issue. Its a minor fix like this, Do you mind testing and submitting a PR. We will patch this.

elamaran11 commented 1 month ago

Issue is fixed.