aws-quickstart / cdk-eks-blueprints

AWS Quick Start Team
Apache License 2.0
430 stars 190 forks source link

(addons/karpenter): (KubernetesVersion.of(1.28) isn't working) #976

Open ROunofF opened 2 months ago

ROunofF commented 2 months ago

Describe the bug

In the windows karpenter pattern we were doing

    kubernetesVersion: eks.KubernetesVersion.of('1.29'),

But that was failing at :

    assert(versionMap.has(kubeVersion), 'Please upgrade your EKS Kubernetes version to start using Karpenter.');

But we had to change to

    kubernetesVersion: eks.KubernetesVersion.V1_29

For our code to pass.

Expected Behavior

No matter how you create the kubernetesVersion it should have to same behavior

Current Behavior

Assert failed

> 748 |         assert(versionMap.has(kubeVersion), 'Please upgrade your EKS Kubernetes version to start using Karpenter.');

Reproduction Steps

I have a test case coming up as PR shortly

Possible Solution

Not an expert, but the versionMap.set() of individuals value seems to provide a more consistent experience. Not sure if this is the best solution.

Additional Information/Context

No response

CDK CLI Version

2.135.0 (build d46c474)

EKS Blueprints Version

1.14.1

Node.js Version

v21.7.1

Environment details (OS name and version, etc.)

MacOS Sonoma 14.3.1

Other information

No response