aws-quickstart / cdk-eks-blueprints

AWS Quick Start Team
Apache License 2.0
424 stars 188 forks source link

[Karpenter] Fix ignored namespace prop #985

Closed muckelba closed 1 month ago

muckelba commented 1 month ago

I've stumbled across a bug while installing karpenter: I can set the namespace in the KarpenterAddOnProps, but the createNamespace() and createServiceAccount() functions would still use the default variable as their namespace.

shapirov103 commented 1 month ago

@youngjeong46 please have a look, I see you have hardcoded the namespace, was there a particular reason for it?

shapirov103 commented 1 month ago

/do-e2e-tests