Closed tjpatter closed 8 years ago
santiagocardenas
commented
8 years ago Hi Timothy, Thanks for the contribution. However, I think you modified every line (possibly spacing) and it's not very practical to see the exact changes you made. Can you please fix that and redo the pull request?
Thanks, Santiago
tjpatter
commented
8 years ago Gah. My bad. Yes, for sure!
On Monday, July 11, 2016, Santiago Cardenas notifications@github.com wrote:
Hi Timothy, Thanks for the contribution. However, I think you modified every line (possibly spacing) and it's not very practical to see the exact changes you made. Can you please fix that and redo the pull request?
Thanks, Santiago
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/aws-quickstart/quickstart-aws-vpc/pull/1#issuecomment-231865724, or mute the thread https://github.com/notifications/unsubscribe/AEse1ajplkOAbxUMs1w95iG71eDz6NQsks5qUrDhgaJpZM4JJsc5 .
Timothy J. Patterson AWS Certified Solutions Architect Professional, DevOps Engineer Professional, Solutions Architect Associate, SysOps Associate, Developer Associate 2014-2016 VMware vExpert, VCAP5-DCA, VCAP5-DCD, Virtual Design Master - vDM002 1650 Hartel Road, Charlotte, MI 48813 989.213.8391 | http://timsvirtualworld.com | Twitter: @awschamp
…S3 VPC Endpoint to private subnets.
As a user of this QuickStart, it was very hard to use the resources it created as nothing had a 'Name' tag. I have modified the template to tag resources appropriately. For example, a subnet could end up with a Name tag of 'DevVPC-private-us-east-1b'. These tags are derived automatically via parameters and environmental information. I have continued the use of the conditionals throughout.
Additionally, I have added a S3 endpoint and associated it with the proper route tables (also continuing the use of the conditionals). Why not send traffic local to S3 instead of relying on NAT / NAT Gateway?