search

aws-quickstart / quickstart-aws-vpc

Amazon Virtual Private Cloud—AWS Solution
Apache License 2.0
325 stars 283 forks source link

Adding Additional Parameters for Creating a Private VPC #28

Closed tbulding closed 4 years ago

tbulding commented 4 years ago

Parameters: CreatePublicSubnets - default value: True CreateNATGateways - default value: True

Rules:
  NAT:
    RuleCondition: !Equals [!Ref CreateNATGateways, "true"]
    Assertions:
      - Assert: !And
          - !Equals [!Ref CreatePrivateSubnets, "true"]
          - !Equals [!Ref CreatePublicSubnets, "true"]
        AssertDescription: To enable NAT gateways you must have both CreatePrivateSubnets and CreatePublicSubnets set to 'true'
  Subnets:
    Assertions:
      - Assert: !Or
          - !Equals [!Ref CreatePrivateSubnets, "true"]
          - !Equals [!Ref CreatePublicSubnets, "true"]
        AssertDescription: At least one of CreatePublicSubnets or CreatePrivateSubnets must be set to 'true'

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

jaymccon commented 4 years ago

can we clean up the .taskcat.yml config, the autogenerated one is full of duplication. We could also be testing in every region.

vsnyc commented 4 years ago

Agree with @jaymccon and @andrew-glenn the PR is hard to read due to the style refactoring. Please undo the style refactoring changes and keep only the functional ones.

tbulding commented 4 years ago

I will be resubmitting a cleaner pull request