No private subnets does not work with NatGWEnabled

aws-quickstart / quickstart-aws-vpc

Amazon Virtual Private Cloud—AWS Solution

Apache License 2.0

327 stars 283 forks source link

No private subnets does not work with NatGWEnabled #30

Closed gargana closed 2 years ago

gargana commented 4 years ago

Problem "Private Subnets" : False does not work in conjunction with "CreateNATGateways" : True Suggested Fix Enforce a check to fail this early via "Rules"

sadlerwcb commented 3 years ago

FYI this is preventing me and probably others from using the AWS quickstart at https://aws-quickstart.s3.amazonaws.com/quickstart-splunk-enterprise/doc/splunk-enterprise-on-the-aws-cloud.pdf. What is the suggested workaround? I spent the last hour tracking it down and came here to create the issue when I should have just looked at the issues here to start :-)

Just use PrivateSubnetsCondition instead of NatGatewaysCondition?

tlindsay42 commented 2 years ago

Fixed in af52dd7d7f32aea532e5b47b21bd91b178897902