search

aws-quickstart / quickstart-aws-vpc

Amazon Virtual Private Cloud—AWS Solution
Apache License 2.0
327 stars 283 forks source link

Parameter mismatch (deprecated params) #40

Closed ytugarev closed 2 years ago

ytugarev commented 2 years ago

This commit [https://github.com/aws-quickstart/quickstart-aws-vpc/commit/1f9a7bebc434f9a38b0ed4d4dd80d438d4d26204] (https://github.com/aws-quickstart/quickstart-aws-vpc/commit/1f9a7bebc434f9a38b0ed4d4dd80d438d4d26204) brakes other *master templates, like https://github.com/aws-quickstart/quickstart-microsoft-activedirectory/blob/master/templates/ad-master-1.template They all call quickstart-aws-vpc/templates/aws-vpc.template.yaml with KeyPair param which cause stack deployment to fail

tlindsay42 commented 2 years ago

Correct- it was a breaking change, and the parameter must be removed to consume this on or after that commit.