Fixes for "DNG AWS Quickstart template improvements" issue

[opavlyshyn]

Fixed points described in opened issue - https://github.com/aws-quickstart/quickstart-cisco-duo-network-gateway/issues/21

Points:

• Default Auth token value (DuoRedisAuthToken) for the for the Redis cluster does not meet the default requirements (number of characters, need special chars, etc). This causes the deployment to FAIL and only after navigating the multiple levels of logs did we see that this is caused by this.

• Quickstart still installs using old: Version (1.5.9) of DNG Admin. Version (1.5.12) of DNG Portal.

• Redis cluster version is EOL-ing on 07/31/2023. (https://docs.aws.amazon.com/AmazonElastiCache/latest/red-ug/deprecated-engine-versions.html)

• ???"launch configuration" for AutoScaling-related settings is used. It is a feature that will no longer be supported by AWS. It cannot be created by even manual either, "launch templates" is encouraged by AWS, instead.

Also, fixed linters, as there were errors not related to this changes.

[mufaddalq]

reviewed and approving changes from my end. @sshvans please merge

[opavlyshyn]

reviewed and approving changes from my end. @sshvans please merge

@sshvans could u please take a look at it?

[opavlyshyn]

reviewed and approving changes from my end. @sshvans please merge

@mufaddalq could u please support us to have this merged? as @sshvans is not reachable

[opavlyshyn]

Looks good to me!

EDIT -- it looks like DescribeAddresses would be for Elastic IPs, not Network Interfaces, so the ARN should be different...IF you wanted to specify that.

@BradBloomingdale could u please support us to have this merged? cuz @sshvans is not reachable, we have customer asking for this

[BradBloomingdale]

Looks good to me! EDIT -- it looks like DescribeAddresses would be for Elastic IPs, not Network Interfaces, so the ARN should be different...IF you wanted to specify that.

@BradBloomingdale could u please support us to have this merged? cuz @sshvans is not reachable, we have customer asking for this

I'm actually a customer myself, and don't have code-owner abilities

[opavlyshyn]

Looks good to me! EDIT -- it looks like DescribeAddresses would be for Elastic IPs, not Network Interfaces, so the ARN should be different...IF you wanted to specify that.

@BradBloomingdale could u please support us to have this merged? cuz @sshvans is not reachable, we have customer asking for this

I'm actually a customer myself, and don't have code-owner abilities oh gotcha

[BradBloomingdale]

Looks good to me! EDIT -- it looks like DescribeAddresses would be for Elastic IPs, not Network Interfaces, so the ARN should be different...IF you wanted to specify that.

@BradBloomingdale could u please support us to have this merged? cuz @sshvans is not reachable, we have customer asking for this

I'm actually a customer myself, and don't have code-owner abilities oh gotcha

Something else -- I'm not able to find any examples of ARNs for Elastic IP addresses, either via the CLI or the console. We know the alternative that was in place won't work because it needs to be fully qualified and Cloudformation will throw an error.

And it appears that Cloudformation doesn't provide an ARN for them either:

Return values
Ref
When you pass the logical ID of this resource to the intrinsic Reffunction, Refreturns the Elastic IP address.

For more information about using the Reffunction, see [Ref](https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/intrinsic-function-reference-ref.html).

Fn::GetAtt
The Fn::GetAttintrinsic function returns a value for a specified attribute of this type. The following are the available attributes and sample return values.

For more information about using the Fn::GetAttintrinsic function, see [Fn::GetAtt](https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/intrinsic-function-reference-getatt.html).

AllocationId
The ID that AWS assigns to represent the allocation of the address for use with Amazon VPC. This is returned only for VPC elastic IP addresses. For example, eipalloc-5723d13e.

PublicIp
The Elastic IP address.

From: https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-ec2-eip.html

[opavlyshyn]

Looks good to me! EDIT -- it looks like DescribeAddresses would be for Elastic IPs, not Network Interfaces, so the ARN should be different...IF you wanted to specify that.

@BradBloomingdale could u please support us to have this merged? cuz @sshvans is not reachable, we have customer asking for this

I'm actually a customer myself, and don't have code-owner abilities oh gotcha

Something else -- I'm not able to find any examples of ARNs for Elastic IP addresses, either via the CLI or the console.

And it appears that Cloudformation doesn't provide an ARN for them either:

Return values
Ref
When you pass the logical ID of this resource to the intrinsic Reffunction, Refreturns the Elastic IP address.

For more information about using the Reffunction, see [Ref](https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/intrinsic-function-reference-ref.html).

Fn::GetAtt
The Fn::GetAttintrinsic function returns a value for a specified attribute of this type. The following are the available attributes and sample return values.

For more information about using the Fn::GetAttintrinsic function, see [Fn::GetAtt](https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/intrinsic-function-reference-getatt.html).

AllocationId
The ID that AWS assigns to represent the allocation of the address for use with Amazon VPC. This is returned only for VPC elastic IP addresses. For example, eipalloc-5723d13e.

PublicIp
The Elastic IP address.

From: https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-ec2-eip.html

yep, that's right..I`d rather leave it as it was for now, then will spend some time investigating it. as customer would like to know when it could be merged and ready.

[opavlyshyn]

@mufaddalq could u please advise what granular permission we can grant for the AdminServerInstancePolicy instead of * in both place for Resource: '*'?

[opavlyshyn]

Hey @BradBloomingdale! Could u please deploy and check the latest changes again?

[BradBloomingdale]

Hey @BradBloomingdale! Could u please deploy and check the latest changes again?

I'm assuming that the EC2 instance ARN could work if the API calls are targeting addresses, but I am unable to test because we only have this solution running in production.

[mufaddalq]

@sshvans : Reviewed and approved from my side. Can we please merge this PR?

[mufaddalq]

@sshvans : Reviewed and approved from my side. Can we please merge this PR?

@sshvans : Gentle reminder for this. Please merge.

[sshvans]

/do-e2e-tests

[aws-ia-ci[bot]]

While attempting to create a backend CI pipeline for this project, I encountered an error loading the .metadata file from the main branch and this PR. Here is a valid example for your reference.