search

aws-quickstart / quickstart-cisco-meraki-sd-wan-vmx

AWS Quick Start Team
Apache License 2.0
11 stars 16 forks source link

Remove unnecessary variable. #27

Closed myhomenwlab closed 2 years ago

myhomenwlab commented 2 years ago

Remove the Meraki Dashboard API Key variable from the AWS Lambda environment variable. Meraki Dashboard API Key is stored in AWS Secrets Manager.

Issue: #26

simarbir commented 2 years ago

Thanks for the fix @myhomenwlab, looks good to me. @sshvans - can we merge this PR?

sshvans commented 2 years ago

/do-e2e-tests

aws-ia-ci[bot] commented 2 years ago

While attempting to create a backend CI pipeline for this project, I encountered an error loading the .metadata file from the main branch and this PR. Here is a valid example for your reference.

sshvans commented 2 years ago

@simarbir Can you add .meatadata file at the project root with the following content language_type: cloudformation Its required by our CI to test the templates before merge. As soon as you addd it to the PR, I'll kickoff a test and merge the PR.

sshvans commented 2 years ago

/do-e2e-tests

aws-ia-ci[bot] commented 2 years ago

I'm creating a backend CI pipeline for this project. This is a one-time procedure but will add a delay of approximately 5 minutes.