search

aws-quickstart / quickstart-cisco-meraki-sd-wan-vmx

AWS Quick Start Team
Apache License 2.0
10 stars 16 forks source link

Fix reference to MerakiApiKey camel casing fix #31

Closed Redick0x7E1 closed 2 years ago

Redick0x7E1 commented 2 years ago

This previously would cause no definition error in lambda.

Issue #, if available:

*Description of changes:

Updating camel casing to reduce definition errors from lambda.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

troy-ameigh commented 2 years ago

/do-e2e-tests

damag commented 1 year ago

Hi, this merged PR causes a KeyError for me, and checking the CloudFormation template, the key of the SecretString is in fact all lowercase:

  SecretString: !Sub '{"merakiapikey":"${MerakiAPIKey}" }'

https://github.com/aws-quickstart/quickstart-cisco-meraki-sd-wan-vmx/blob/510a621e2e5455bfb6907c81a0b05284e0bd7c5d/templates/quickstart-cisco-meraki-sdwan-vmx-tgw.yaml#L122C45-L122C45

Seems perhaps there was some confusion between the name of the sercret resource and the key of the SecretString?