search

aws-quickstart / quickstart-cisco-meraki-sd-wan-vmx

AWS Quick Start Team
Apache License 2.0
11 stars 16 forks source link

bug in check for vmx instances #36

Open kamatsuoka opened 1 year ago

kamatsuoka commented 1 year ago

This line clearly has a logic problem:

https://github.com/aws-quickstart/quickstart-cisco-meraki-sd-wan-vmx/blob/510a621e2e5455bfb6907c81a0b05284e0bd7c5d/functions/source/lambda_function.py#L209

Should it be

if (ec2_vmx1_id and meraki_vmx1_id) or (ec2_vmx2_id and meraki_vmx2_id):

to check that at least one vmx has both an ec2 and a meraki id?