search

aws-quickstart / quickstart-citrix-daas

AWS Quick Start Team
Apache License 2.0
1 stars 1 forks source link

Updating submodules #39

Closed vsnyc closed 1 year ago

vsnyc commented 1 year ago

Issue #, if available: Fixes #34

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

skymoore commented 1 year ago

@tlindsay42 I understand @vsnyc is presently not able to do a complete e2e due to expired licenses. I can do it. Can you point me to some docs or anything describing what you need to see to merge this?

vsnyc commented 1 year ago

Last e2e test: https://github.com/aws-quickstart/quickstart-citrix-daas/pull/29#pullrequestreview-1054104052

tlindsay42 commented 1 year ago

@skymoore You bet. Would you post a screenshot of a successful deployment in the AWS CloudFormation console, please? I recommend redacting the account number at a minimum. Here's a recent example: https://github.com/aws-quickstart/quickstart-amazon-eks/pull/471#issuecomment-1338343387.

skymoore commented 1 year ago

@tlindsay42 @vsnyc I love it when work evaporates like that. Thanks friends.