search

aws-quickstart / quickstart-clickhouse-cluster

AWS Quick Start Team
Apache License 2.0
14 stars 16 forks source link

Parameter 'ClickHouseVersion' must be one of AllowedValues #51

Open offlinejke opened 2 years ago

offlinejke commented 2 years ago

Is it possible to update Clickhouse version after deployment? Added new clickhouse version into "AllowedValues" in current template. Also used it as a "Default" version and saved to s3 Can not update cluster due to the error.

felipegs31 commented 2 years ago

I am having a related issue, I updated the value to 22.7.3.5 in the yml to create the stack with this version and I have errors in cloudformation image

qiaow02 commented 2 years ago

Hi, After deployment, you can update the ClickHouse version using ClickHouse Upgrade manually. To deploy a new ClickHouse cluster with the new version using CloudFormation template, you need more work to do. The CloudFormation template will update the config.xml to add the new cluster setting with hard code, because the config.xml varied from every new version of ClickHouse. You can find the logic from 294 to 300 lines in clickhouse-install.sh.

if [ $1 = 21.4.5.46-2 ]; then echo "Update the config.xml of $1" sed -i '508, 617d' /etc/clickhouse-server/config.xml elif [ $1 = 21.5.5.12-2 ]; then echo "Update the config.xml of $1" sed -i '520, 630d' /etc/clickhouse-server/config.xml fi

To support new version of the ClickHouse, you have to add some codes here to make sure the config.xml will be updated correctly.

BTW, It is not supported to update the existing cluster using CloudFormation template.

Thanks.