search

aws-quickstart / quickstart-freeradius-mfa-workspaces

AWS Quick Start Team
Apache License 2.0
1 stars 3 forks source link

Amazon WorkSpaces MFA-Enabled Quick Start #3

Closed metabc closed 2 years ago

metabc commented 2 years ago

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

sshvans commented 2 years ago

@metabc There is still a lint issue. Please resolve it before I can test and merge. BTW, everytime you push a commit, CI runs a lint check. You can come back in few minutes to check if linting passed. It will help expedite the review process and back and forth over slack or email.

metabc commented 2 years ago

@sshvans, I've cleaned up scenario 3 template files for now. Work on that scenario is still in progress. Will commit once we've completed the necessary work.

sshvans commented 2 years ago

/do-e2e-tests

aws-ia-ci[bot] commented 2 years ago

While attempting to create a backend CI pipeline for this project, I encountered an error loading the .metadata file from the main branch and this PR. Here is a valid example for your reference.

sshvans commented 2 years ago

/do-e2e-tests

sshvans commented 2 years ago

/do-e2e-tests

andrew-glenn commented 2 years ago

/do-e2e-tests

aws-ia-ci[bot] commented 2 years ago

No record of this PR's linting checks is available. If the checks are in progress, please wait until they're finished.

If the checks are complete, please convert this PR to DRAFT, then return to READY to re-trigger linting runs.

When ready, please submit another comment with /do-e2e-tests

andrew-glenn commented 2 years ago

/do-e2e-tests

aws-ia-ci[bot] commented 2 years ago

I'm creating a backend CI pipeline for this project. This is a one-time procedure but will add a delay of approximately 5 minutes.

metabc commented 2 years ago

Tests are failing in our CI due to inccorect values for QSS3KeyPrefix. HAve you tested the code with taskcat? If not, can you please do so? If Yes, then please ensure that any override values you are using in your taskcat fiile is provided to me for testing.

Yes, this has been tested with taskcat in different AWS accounts and regions.

sshvans commented 2 years ago

/do-e2e-tests

sshvans commented 2 years ago

/do-e2e-tests