aws-quickstart / quickstart-github-enterprise

AWS Quick Start Team
Apache License 2.0
22 stars 22 forks source link

GHELicense description needs to note that it cant begin with a forward slash #18

Open ju2wheels opened 5 years ago

ju2wheels commented 5 years ago

https://github.com/aws-quickstart/quickstart-github-enterprise/blob/develop/templates/quickstart-github-enterprise-master.template#L144-L147 https://github.com/aws-quickstart/quickstart-github-enterprise/blob/develop/templates/quickstart-github-enterprise.template#L273-L276

GHELicense is like QSS3KeyPrefix and should note that it cannot start with a forward slash because that is already added by the aws s3 cp in the scripts/.

The description should also be clarified to note that its the location from where the install will look for the license and not where the install process will upload it to (you have to upload it there yourself). The description is a bit confusing as to the usage of the parameter (e.g. that is the location read from and not a location written to).

One of the issues that can cause #7