Closed shaithal closed 4 years ago
Please review @vsnyc . Attached taskcat report taskcat_report.zip
@parthakom2-zz fyi
I've made several changes with respect to parameter labels and descriptions. Will share them in a new pull request after merging this in.
For this PR, two main comments:
The inline bootnode-policy
had the following to allow access to the QSS3Bucket.
Resource: !Sub 'arn:aws:s3:::${QSS3BucketName}/${QSS3KeyPrefix}*'
It needs to be changed to:
Resource: !Sub
- arn:${AWS::Partition}:s3:::${S3Bucket}/${QSS3KeyPrefix}*
- S3Bucket: !If [UsingDefaultBucket, !Sub '${QSS3BucketName}-${AWS::Region}', !Ref QSS3BucketName]
Two additional questions based on reviewing documentation:
APIUsername
: should it have a default value of cp
? Or should we remove it because it will be obtained by the user?PortworxSpec
: is it always needed or should there be a default value of empty string: ""?@vsnyc yes, I will update bootnode policy to look for QSS3Bucket region and get S3Bucket added to Resource arn. APIUsername by default would be cp once we move to IBM Cloud registry after GA, unless any exception or future change. I think we have a documentation reference added for it. @parthakom2-zz please confirm. PortworxSpec is optional and only required when storage is selected as portworx.
Issue #, if available:
Description of changes:
Openshift 4.3.x support Changes include support for RH OCS , Portworx as storage along with EFS. Additional services Spark and Cognos Dashboard
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.