aws-quickstart / quickstart-microsoft-activedirectory

AWS Quick Start Team
Apache License 2.0
113 stars 113 forks source link

Updated Parameter Input Validations. #169

Closed relmota closed 1 year ago

relmota commented 1 year ago

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

davmayd commented 1 year ago

/do-e2e-tests

shankara-n commented 1 year ago

template1 breaks when parameter PKI is set to "two tier" on mainline. does this PR fix it?

relmota commented 1 year ago

Hi Shankara , This PR is fixing issues with templates 3 for AD , plus Management template. Template 1 tested and built fine with “Two tier” . I will take a look at it .

-Reda

From: Shankara Narayana @.> Sent: Friday, December 23, 2022 5:12 PM To: aws-quickstart/quickstart-microsoft-activedirectory @.> Cc: Elmotassadeq, Reda @.>; Author @.> Subject: Re: [aws-quickstart/quickstart-microsoft-activedirectory] Updated Parameter Input Validations. (PR #169)

template1 breaks when parameter PKI is set to "two tier" on mainline. does this PR fix it?

— Reply to this email directly, view it on GitHubhttps://github.com/aws-quickstart/quickstart-microsoft-activedirectory/pull/169#issuecomment-1364362109, or unsubscribehttps://github.com/notifications/unsubscribe-auth/A2HBHZVD6QX3ISZSNWOGPC3WOYPTTANCNFSM6AAAAAATETQJ7M. You are receiving this because you authored the thread.Message ID: @.**@.>>