search

aws-quickstart / quickstart-microsoft-rdgateway

AWS Quick Start Team
Apache License 2.0
48 stars 87 forks source link

reordering of template parameter options and some textual merging #27

Closed bennettellis closed 4 years ago

bennettellis commented 4 years ago

The templates as they are currently have some discrepancies that are not real discrepancies, which will cause them to be a bit harder to maintain. By syncing parameter order between these two and removing insignificant textual varaince, they will allow for better maintenance since these two are copies of eachother with slight varaince for Domain joined vs Standalone. Making this change allows for a DIFF between them that doesn't present false-positive diff entries.

Issue #, if available:

Description of changes: Reordered parameter options between these two so that they match so that they don't create false-positive DIFFs and merged a few lines of text (descriptions) for the same reason (these text variances seem more like accidents than real valuable divergences)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

vsnyc commented 4 years ago

@bennettellis Thanks for the contribution. I agree with the suggested changes.