search

aws-quickstart / quickstart-microsoft-rdgateway

AWS Quick Start Team
Apache License 2.0
48 stars 87 forks source link

Update and parameterize the key length #3

Closed LawrenceHwang closed 7 years ago

LawrenceHwang commented 7 years ago

Hello,

The key length, 1024, isn't ideal. Updating it to 2048 can increase the security level and it also matches the default value of ACM.

Parameterizing the key length provides possibility to specify it from the CFN.

Formatted with VSCode.

Thanks,

Lawrence

santiagocardenas commented 7 years ago

This is great @LawrenceHwang . However, can you please revert the formatting to the 4-space tabs that were there in place? I'll likely just end up squashing before merge.

Also, please confirm that your contribution is under the Apache 2.0 license terms.

Thanks! Santiago

LawrenceHwang commented 7 years ago

Thank you @santiagocardenas ! Sorry about the spacing changes. I've updated the file. Please feel free to let me know if anything 👍

Yes, my contribution is under the Apace 2.0 license terms.

Thanks!

Lawrence