aws-quickstart / quickstart-mongodb-atlas

AWS Quick Start Team
Apache License 2.0
20 stars 13 forks source link

Please put back the S3 files #39

Closed sverraest closed 1 year ago

sverraest commented 1 year ago

Hi there, we're using the MongoDB Atlas resources registration template from this bucket, however the files seem to be removed. Any chance these can be put back to avoid breaking infrastructure changes?

sverraest commented 1 year ago

The missing file is register-mongodb-atlas-resources.yaml

sverraest commented 1 year ago
Resources:
  RegisterAtlasResources:
    Condition: RegisterResources
    Type: AWS::CloudFormation::Stack
    Properties:
      TemplateURL: !Sub
        - 'https://${S3Bucket}.s3.${S3Region}.${AWS::URLSuffix}/${QSS3KeyPrefix}templates/register-mongodb-atlas-resources.yaml'
        - S3Region: !If [UsingDefaultBucket, !Ref 'AWS::Region', !Ref QSS3BucketRegion]
          S3Bucket: !If [UsingDefaultBucket, !Sub '${QSS3BucketName}-${AWS::Region}', !Ref QSS3BucketName]
      Parameters:
        QSS3BucketName: !Ref QSS3BucketName
        QSS3KeyPrefix: !Ref QSS3KeyPrefix

This file specified in TemplateURL is no longer available

sverraest commented 1 year ago

And the zips for the custom lambda functions such as

copy_source: {'Bucket': 'aws-quickstart', 'Key': 'quickstart-mongodb-atlas/functions/packages/quickstart-mongodb-atlas-resources/mongodb-atlas-project.zip'}

Have also been removed, breaking even more deployments.

vsnyc commented 1 year ago

Hi Simon, apologies you are running into trouble with this. The solution has been updated to use public CloudFormation registry resource types, thus using register-mongodb-atlas-resources.yaml is no longer necessary. The resources in quickstart-mongodb-atlas-resources had become outdated and MongoDB has been publishing updates including newer resource types to CloudFormation registry.

If you review the old code, it was written to work with public types as well, where you activate the types first and then deploy the solution with RegisterMongoDBResources set to No, in that case the private resources and the template you are mentioning is no longer necessary.

Alternatively, if you must go back, please clone the repo recursively to your own S3 bucket and deploy/update the CloudFormation stack from there. You can choose to work at the commit level: https://github.com/aws-quickstart/quickstart-mongodb-atlas/tree/190c3aded2995da9cc220f8ffe85cf966d71f8cd which has the code your are looking for. Please feel free to reach out to me on LinkedIn (link in bio) if I can help in any way.

sverraest commented 1 year ago

@vsnyc I appreciate there are updates but if this is offered as a quickstart these breaking changes should be versioned so that previous implementations don't break. We're reliant on the previous implementation on this, that still works.

vsnyc commented 1 year ago

We don't support versioning in our S3 buckets, but I've created a GitHub release for the old code here: https://github.com/aws-quickstart/quickstart-mongodb-atlas/releases/tag/v1.0.0