search

aws-quickstart / quickstart-neo4j

AWS Quick Start Team
Apache License 2.0
5 stars 2 forks source link

Lint Warnings - Interface #22

Closed benofben closed 2 years ago

benofben commented 2 years ago

We're getting a bunch of lint warnings about a missing interface. This appears to be a newer metadata construct in CFT. I'm not sure we want to incorporate it as it's a lot of lines of code and our interface is dead simple.

Here's an example of how Aerospike does it: https://github.com/aws-quickstart/quickstart-aerospike/blob/622b137f4814387fddd394f3d5d10547ca589449/templates/aerospike-cluster-workload.template.yaml#L29

Here are some of our warning messages: [cfn-lint] W9002: Parameter Version is missing ParameterLabel [cfn-lint] W9003: Parameter Version is not in a ParameterGroup

veeragoni commented 2 years ago

warnings can be ignored. its nice to have, not a must. errors need to be fixed.

benofben commented 2 years ago

Got it. Thinking we don't worry about this then. Maybe clean it up later depending on how conversations with the Marketplace team look.

benofben commented 2 years ago

I added an interface and got rid of all the group ones. Still torn about adding the label. That seems to duplicate the text in description.

benofben commented 2 years ago

So, this deploys cleanly: https://github.com/neo4j-partners/quickstart-neo4j/commit/c483b2989ad62c715bbbe54beebeb7d6291fa4c2

But.... I'm getting lint errors still.
image

veeragoni commented 2 years ago

lint error fix is in another issue.

benofben commented 2 years ago

@veeragoni this issue is specifically about the warnings above. Can you advise on the warnings?

veeragoni commented 2 years ago

we need to add override to suppress the warnings/errors that can't be removed. I can update that

veeragoni commented 2 years ago

there was a spacing issue with the labels. i fixed it. get latest @benofben

benofben commented 2 years ago

ahhhh. thanks! of course it was user error....