search

aws-quickstart / quickstart-vmware-tanzu-application-platform

AWS Quick Start for VMware Tanzu Application Platform
https://aws-quickstart.github.io/quickstart-vmware-tanzu-application-platform/
Apache License 2.0
13 stars 15 forks source link

Added AllowedPattern for RemoteAccessCidr parameter #102

Closed spagno closed 2 years ago

spagno commented 2 years ago

Issue #, if available:

Description of changes: Added an AllowedPattern to check the RemoteAccessCidr parameter. It's a required parameter otherwise it will cause an error in CloudFormation

Embedded stack arn:aws:cloudformation:us-east-1:816333157034:stack/vmware-tanzu-application-platform-1-2-ExistingVpcStack-7UAE0RNJB7RV/be9c4d20-0c1e-11ed-b0ef-0ebb957d5521 was not successfully created: The following resource(s) failed to create: [LinuxBastionSshIngressRule, WindowsBastionRdpIngressRule, EKSQSStack].

As remote CIDR is unique to each customer, we cannot provide a secure default without opening remote access to the world.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

tlindsay42 commented 2 years ago

/do-e2e-tests

tlindsay42 commented 2 years ago

Merging per discussion with @satya-dillikar. Thanks @spagno!

satya-dillikar commented 2 years ago

Thanks, @spagno for taking care of this.
Thanks, @tlindsay42 for taking care of merging and pushing this to AWS QS S3 buckets also.