search

aws-quickstart / quickstart-vmware-tanzu-application-platform

AWS Quick Start for VMware Tanzu Application Platform
https://aws-quickstart.github.io/quickstart-vmware-tanzu-application-platform/
Apache License 2.0
13 stars 15 forks source link

cosmetic internal comments #105

Closed satya-dillikar closed 2 years ago

satya-dillikar commented 2 years ago

Issue #, if available:

Description of changes:

User Feedback (internal comments) taken care:

  1. Rename 'TAP' To 'VMware' in user-visible resource names.
  2. Update the helper text for Username to use 'Tanzu' instead of a 'Pivotal' link

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

satya-dillikar commented 2 years ago

The diff is just cosmetic. @tlindsay42, please check if the qs linter is broken.

I tried to run it manually on my terminal and got the same error.

cfn-lint aws-tap-entrypoint-existing-vpc.template.yaml -a ~/vmw_code/vmw-tanzu-tap/qs-cfn-lint-rules/qs_cfn_lint_rules
E0002 Unknown exception while processing rule W9006: __init__() got an unexpected keyword argument 'encoding'
aws-tap-entrypoint-existing-vpc.template.yaml:1:1
tlindsay42 commented 2 years ago

/do-e2e-tests

tlindsay42 commented 2 years ago

e2e failed likely due to https://github.com/aws-ia/taskcat/pull/759. Researching...

tlindsay42 commented 2 years ago

/do-e2e-tests