search

aws-quickstart / quickstart-vmware-tanzu-application-platform

AWS Quick Start for VMware Tanzu Application Platform
https://aws-quickstart.github.io/quickstart-vmware-tanzu-application-platform/
Apache License 2.0
13 stars 15 forks source link

Remove explicit disabling of partner integrations, fix nesting, and bump the EKS submodule to latest #123

Closed aaronmeza closed 1 year ago

aaronmeza commented 1 year ago

The explicit disabling of EKS partner integrations that no longer exist is causing the EKS stack to fail to deploy. Removing as this is unnecessary as they will never be enabled by default. Additionally, we know that in the future more of these may be removed.

Issue #, if available:

122

Description of changes: remove explicit disabling of EKS partner integraions

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

tlindsay42 commented 1 year ago

/do-e2e-tests

tlindsay42 commented 1 year ago

/do-e2e-tests

tlindsay42 commented 1 year ago

/do-e2e-tests

tlindsay42 commented 1 year ago

/do-e2e-tests

tlindsay42 commented 1 year ago

@aaronmeza I had to bump the EKS submodule to latest as part of this due to a sporadic bug popping up in CI that has since been fixed (local builds were fine). Bonus: I noticed that https://github.com/aws-quickstart/quickstart-amazon-eks/issues/418 appears to be resolved as part of this.

@leclaist Since I took care of upgrading the EKS submodule, you'll probably need to rebase your feature branch for your PR for #107, but now you only need to update the templates.