aws-quickstart / quickstart-vmware-tanzu-application-platform

AWS Quick Start for VMware Tanzu Application Platform
https://aws-quickstart.github.io/quickstart-vmware-tanzu-application-platform/
Apache License 2.0
13 stars 15 forks source link

TAP 1.4.0 New Release QS Code Changes #128

Closed satya-dillikar closed 1 year ago

satya-dillikar commented 1 year ago

Issue #, if available:

Description of changes:

satya-dillikar commented 1 year ago

@tlindsay42 , Please take care of a few files during Merge.

PS: I have some difficulty excluding a few files in PR. Hence, I am not sure how to restore the above to the correct files.

satya-dillikar commented 1 year ago
  • Need to re-add the EKS submodule as it was deleted.

    • Not sure of how e2e tests worked without it. ?
  • Need to fix all of the ARNs to sub the AWS::Partition pseudo-parameter
  • Need to fix the parameter & output descriptions.
  • Other suggestions below.

Done. Please check.

tlindsay42 commented 1 year ago

/do-e2e-tests

tlindsay42 commented 1 year ago

/do-e2e-tests

tlindsay42 commented 1 year ago

/do-e2e-tests

tlindsay42 commented 1 year ago

/do-e2e-tests

tlindsay42 commented 1 year ago

/do-e2e-tests

tlindsay42 commented 1 year ago

/do-e2e-tests

tlindsay42 commented 1 year ago

/do-e2e-tests

satya-dillikar commented 1 year ago

@satya-dillikar Almost there. Need you to either update the outputs with insufficient description values or remove them. Removing the excess quotes is optional.

After that, all that's left on this PR should be for @annaone to review the descriptions for the new parameter & outputs for both templates when she's back. Once approved, we should be all set for this one for launch.

@tlindsay42, done. please start e2e.

tlindsay42 commented 1 year ago

/do-e2e-tests

satya-dillikar commented 1 year ago

Replaced with #131