Closed satya-dillikar closed 1 year ago
@tlindsay42 , Please take care of a few files during Merge.
PS: I have some difficulty excluding a few files in PR. Hence, I am not sure how to restore the above to the correct files.
Need to re-add the EKS submodule as it was deleted.
- Not sure of how e2e tests worked without it. ?
- Need to fix all of the ARNs to sub the
AWS::Partition
pseudo-parameter- Need to fix the parameter & output descriptions.
- Other suggestions below.
Done. Please check.
/do-e2e-tests
/do-e2e-tests
/do-e2e-tests
/do-e2e-tests
/do-e2e-tests
/do-e2e-tests
/do-e2e-tests
@satya-dillikar Almost there. Need you to either update the outputs with insufficient description values or remove them. Removing the excess quotes is optional.
After that, all that's left on this PR should be for @annaone to review the descriptions for the new parameter & outputs for both templates when she's back. Once approved, we should be all set for this one for launch.
@tlindsay42, done. please start e2e.
/do-e2e-tests
Replaced with #131
Issue #, if available:
Description of changes:
Complete End-to-End validation of TAP 1.4.0 on single & multi cluster deployments
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.