aws-quickstart / quickstart-vmware-tanzu-application-platform

AWS Quick Start for VMware Tanzu Application Platform
https://aws-quickstart.github.io/quickstart-vmware-tanzu-application-platform/
Apache License 2.0
13 stars 15 forks source link

[qs] release 1.4.2+aws.1 #149

Closed hoegaarden closed 1 year ago

hoegaarden commented 1 year ago

Description of changes:

user-facing changes:

changes interesting to Troy/AWS:

other (internal) changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

hoegaarden commented 1 year ago

This PR needs to go in in tandem with #150

hoegaarden commented 1 year ago

@tlindsay42 please have a look! Thanks!

Note: Please have a look at the taskcat changes regarding the new tests. Not sure if you need to be aware of that, I just want to make sure your tests run with the correct config for TanzuNetRelocateImages

tlindsay42 commented 1 year ago

@hoegaarden Thanks for calling that out. Checking my override config & will update if needed.

tlindsay42 commented 1 year ago

/do-e2e-tests

tlindsay42 commented 1 year ago

@hoegaarden Will merge once #150 is ready to go

hoegaarden commented 1 year ago

end to end tests passed @hoegaarden Will merge [...]

Sweet!

[...] once #150 is ready to go

Great. I guess you are waiting for your doc writers on that, or is there anything you need from us / anything that's missing on #150 ?

tlindsay42 commented 1 year ago

Great. I guess you are waiting for your doc writers on that,...

Yep 😄

...or is there anything you need from us / anything that's missing on https://github.com/aws-quickstart/quickstart-vmware-tanzu-application-platform/pull/150 ?

Nope, good-to-go from my end 🚀 🎉