search

aws-robotics / aws-robomaker-bookstore-world

A bookstore world with shelving and tables for AWS RoboMaker and Gazebo simulations
MIT No Attribution
68 stars 19 forks source link

Remove all turtlebot related launch files #15

Closed ahtsan closed 4 years ago

ahtsan commented 4 years ago

This repository should be a pure world repository and not having any navigation related code.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

cheng-kevin commented 4 years ago

Are these mapping files in aws-robomaker-bookstore-world/maps/turtlebot3_waffle_pi/ specific to waffle_pi or could they be renamed?

ahtsan commented 4 years ago

Are these mapping files in aws-robomaker-bookstore-world/maps/turtlebot3_waffle_pi/ specific to waffle_pi or could they be renamed?

I think they were generated specifically with waffle_pi, so they can't be renamed. Need to check with @mm318 @samuelgundry

cheng-kevin commented 4 years ago

Are these mapping files in aws-robomaker-bookstore-world/maps/turtlebot3_waffle_pi/ specific to waffle_pi or could they be renamed?

I think they were generated specifically with waffle_pi, so they can't be renamed. Need to check with @mm318 @samuelgundry

Got it. I guess these mappings files would be the last turtlebot3 specific remnants, and do we think this would affect our definition of "pure world repository".

ahtsan commented 4 years ago

Are these mapping files in aws-robomaker-bookstore-world/maps/turtlebot3_waffle_pi/ specific to waffle_pi or could they be renamed?

I think they were generated specifically with waffle_pi, so they can't be renamed. Need to check with @mm318 @samuelgundry

Got it. I guess these mappings files would be the last turtlebot3 specific remnants, and do we think this would affect our definition of "pure world repository".

Good point. It would be ideal to exclude the map files but it is out of this PR's scope. Now we are "navigation-free" but not "turtlebot3-free".

mm318 commented 4 years ago

Yeah, the goal here is to make the ros1 branch consistent with the ros2 branch.

There is unfortunately no clear home for where the Turtlebot-specific occupancy maps should reside, so let's just leave it in the sample world repos for now.

mm318 commented 4 years ago

This change needs to go in atomically with https://github.com/aws-robotics/aws-robomaker-sample-application-cloudwatch/pull/137.