search

aws-robotics / aws-robomaker-sample-application-cloudwatch

Use AWS RoboMaker and demonstrate monitoring robot health and operational metrics with AWS CloudWatch.
MIT No Attribution
20 stars 43 forks source link

Remove "turtlebot3" from .rosinstall #26

Closed mm318 closed 4 years ago

mm318 commented 5 years ago

https://github.com/aws-robotics/aws-robomaker-sample-application-cloudwatch/pull/25 was made for pulling in the fix at https://github.com/ROBOTIS-GIT/turtlebot3/pull/402, but once the fix is released and made available in the ros-melodic-turtlebot3-navigation apt package, https://github.com/aws-robotics/aws-robomaker-sample-application-cloudwatch/pull/25 should be reverted.

xabxx commented 5 years ago

@mm318 PR you referenced in this issue is merged. what's the next step?

mm318 commented 5 years ago

I see that they have bloom released the https://github.com/ROBOTIS-GIT/turtlebot3/pull/402 fix. I don't think it has been synced yet, especially for the melodic distro.

Let's wait until after the sync in September to test and see if we can revert https://github.com/aws-robotics/aws-robomaker-sample-application-cloudwatch/pull/25.

mm318 commented 4 years ago

This issue has been resolved by https://github.com/aws-robotics/aws-robomaker-sample-application-cloudwatch/pull/87.

ahtsan commented 4 years ago

This issue still needs verification.

ahtsan commented 4 years ago

Confirmed the fix has been synced in turtlebot3_navigation package https://github.com/ROBOTIS-GIT/turtlebot3/commit/69b4563d754ad539d2b2c71fe6f968b3419fb3fb